-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for Go custom container builds, link from 2.55.0 release notes. #30290
Conversation
R: @liferoad |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
I got into a groove and went and figured out the right custom container instructions, so no stopgap required. |
I never try that but it should work. BTW: we can also add https://cloud.google.com/dataflow/docs/guides/using-custom-containers to the md file if users need more information about custom containers. |
That file just links to the page I'm already linking to. It's also weird to link to the Dataflow pages from a Beam release for a non-dataflow feature. |
I mean adding this to website/www/site/content/en/documentation/runtime/environments.md if users want to learn more how to do this in general. But it is fine not to do this if you feel it is strange. :) |
I don't feel it's reasonable to conflate adding that link to this PR. I have no idea where I'd put it. I've always found our strategy of essentially putting general Beam content on the Dataflow pages to be baffling, vs improving the content on the Beam pages. |
Add a message to 2.55.0's Breaking Changes regarding the Go container moving to distroless.
While the existing instructions for
https://beam.apache.org/documentation/runtime/environments/#modify-existing-base-image do work, the simplicity of Go's handling in this case is valuable to emphasize.
Staging:
https://apache-beam-website-pull-requests.storage.googleapis.com/30290/documentation/runtime/environments/index.html#from-scratch-go
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.